linux-kernel - Re: [PATCH v2] dmaengine: stm32-dma: Fix unchecked deference of chan->desc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151210041544.GO1854@localhost>
Date:	Thu, 10 Dec 2015 09:45:44 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	M'boumba Cedric Madianga <cedric.madianga@...il.com>
Cc:	dan.j.williams@...el.com, mcoquelin.stm32@...il.com,
	dmaengine@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dmaengine: stm32-dma: Fix unchecked deference of
 chan->desc

On Mon, Dec 07, 2015 at 12:00:28PM +0100, M'boumba Cedric Madianga wrote:
> 'commit d8b468394fb7 ("dmaengine: Add STM32 DMA driver")' leads to the
> following Smatch complaint:
> 
> drivers/dma/stm32-dma.c:562 stm32_dma_issue_pending()
>     error: we previously assumed 'chan->desc' could be null (see line 560)
> 
> So, this patch fixes the unchecked dereference of chan->desc by returning
> operation not permitted error when stm32_dma_start_transfer() does not
> succeed to allocate a virtual channel descriptor.

Applied, thanks

-- 
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/