linux-kernel - Re: [PATCHv3] Input: xpad - Fix double URB submission races

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 9 Dec 2015 22:45:44 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Laura Abbott <labbott@...oraproject.org>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCHv3] Input: xpad - Fix double URB submission races

Hi Laura,

On Mon, Nov 16, 2015 at 02:47:13PM -0800, Laura Abbott wrote:
> +static int __xpad_submit_urb(struct usb_xpad *xpad,
> +			unsigned char odata[XPAD_PKT_LEN], int transfer_length,
> +			int type, bool safe_submit)
> +{
> +	int ret;
> +
> +	if (safe_submit || xpad->submit_state == OUT_IRQ_AVAILABLE) {
> +		memcpy(xpad->odata, odata, transfer_length);
> +		xpad->irq_out->transfer_buffer_length = transfer_length;
> +		ret = usb_submit_urb(xpad->irq_out, GFP_ATOMIC);
> +		xpad->submit_state = OUT_IRQ_QUEUE_EMPTY;
> +		xpad->out_submitter = type;
> +	} else {
> +		/*
> +		 * The goal here is to prevent starvation of any other type.
> +		 * If this type matches what is being submitted and there is
> +		 * another type in the queue, don't ovewrite it
> +		 */
> +		if (xpad->submit_state != OUT_IRQ_QUEUE_EMPTY &&
> +		    xpad->out_submitter == type &&
> +		    xpad->queue_submitter != type) {
> +			ret = -EBUSY;
> +			goto out;

No, we do not want to return "busy" here. We should save the most
up-to-date request of given type and re-submit it when URB is no longer
busy.

I CCed you on another patch addressing the same issue, please take a
look when you have a chance.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/