linux-kernel - Re: [PATCH 7/9v2] usb: host: ehci.h: remove macros trailing semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Dec 2015 11:20:13 +0100
From:	Peter Senna Tschudin <peter.senna@...il.com>
To:	"Geyslan G. Bem" <geyslan@...il.com>
Cc:	Alan Stern <stern@...land.harvard.edu>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/9v2] usb: host: ehci.h: remove macros trailing semicolon

On Wed, Dec 09, 2015 at 07:32:36PM -0300, Geyslan G. Bem wrote:
> Removes trailing semicolon from macros.
> 
> Caught by checkpatch:
> "WARNING: macros should not use a trailing semicolon"
> 
> Signed-off-by: Geyslan G. Bem <geyslan@...il.com>
As with previous, missing the changelog, but other than that the patch
looks good to me.

Acked-by: Peter Senna Tschudin <peter.senna@...il.com>
> ---
>  drivers/usb/host/ehci.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
> index ea56147..15de5bf 100644
> --- a/drivers/usb/host/ehci.h
> +++ b/drivers/usb/host/ehci.h
> @@ -635,10 +635,10 @@ struct ehci_tt {
>  /* Prepare the PORTSC wakeup flags during controller suspend/resume */
>  
>  #define ehci_prepare_ports_for_controller_suspend(ehci, do_wakeup)	\
> -		ehci_adjust_port_wakeup_flags(ehci, true, do_wakeup);
> +		ehci_adjust_port_wakeup_flags(ehci, true, do_wakeup)
>  
>  #define ehci_prepare_ports_for_controller_resume(ehci)			\
> -		ehci_adjust_port_wakeup_flags(ehci, false, false);
> +		ehci_adjust_port_wakeup_flags(ehci, false, false)
>  
>  /*-------------------------------------------------------------------------*/
>  
> -- 
> 2.6.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/