linux-kernel - Re: [PATCH 9/9] usb: host: ehci.h: move constant to right

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151210102332.GI4013@toshiba-peter.rsr.lip6.fr>
Date:	Thu, 10 Dec 2015 11:23:32 +0100
From:	Peter Senna Tschudin <peter.senna@...il.com>
To:	"Geyslan G. Bem" <geyslan@...il.com>
Cc:	Alan Stern <stern@...land.harvard.edu>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 9/9] usb: host: ehci.h: move constant to right

On Wed, Dec 09, 2015 at 07:15:37PM -0300, Geyslan G. Bem wrote:
> This patch moves the constant 0x3ff to right and put spaces
> in the right shift.
> 
> Caught by coccinelle:
> scripts/coccinelle/misc/compare_const_fl.cocci
> 
> Signed-off-by: Geyslan G. Bem <geyslan@...il.com>
Acked-by: Peter Senna Tschudin <peter.senna@...il.com>
> ---
>  drivers/usb/host/ehci.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
> index 81e609a..de94555 100644
> --- a/drivers/usb/host/ehci.h
> +++ b/drivers/usb/host/ehci.h
> @@ -555,7 +555,7 @@ struct ehci_sitd {
>  	__hc32			hw_results;		/* EHCI table 3-11 */
>  #define	SITD_IOC	(1 << 31)	/* interrupt on completion */
>  #define	SITD_PAGE	(1 << 30)	/* buffer 0/1 */
> -#define	SITD_LENGTH(x)	(0x3ff & ((x)>>16))
> +#define	SITD_LENGTH(x)	(((x) >> 16) & 0x3ff)
>  #define	SITD_STS_ACTIVE	(1 << 7)	/* HC may execute this */
>  #define	SITD_STS_ERR	(1 << 6)	/* error from TT */
>  #define	SITD_STS_DBE	(1 << 5)	/* data buffer error (in HC) */
> -- 
> 2.6.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/