linux-kernel - Re: [PATCH] usb: remove redundant conditions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151210104430.GE24965@localhost>
Date:	Thu, 10 Dec 2015 11:44:30 +0100
From:	Johan Hovold <johan@...nel.org>
To:	"Geyslan G. Bem" <geyslan@...il.com>
Cc:	peter.senna@...il.com, Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Johan Hovold <johan@...nel.org>,
	Robert Baldyga <r.baldyga@...sung.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: remove redundant conditions

On Wed, Dec 09, 2015 at 10:52:42PM -0300, Geyslan G. Bem wrote:
> This patch removes redundant conditions.
> 
>  - (!A || (A && B)) is the same as (!A || B).
>  - (length && length > 5) can be reduced to a single evaluation.
> 
> Caught by: cppcheck
> 
> Signed-off-by: Geyslan G. Bem <geyslan@...il.com>
> ---
>  drivers/usb/gadget/udc/s3c-hsudc.c |  2 +-
>  drivers/usb/host/fhci-sched.c      |  2 +-
>  drivers/usb/musb/musb_gadget.c     |  5 ++---
>  drivers/usb/serial/io_edgeport.c   | 35 ++++++++++++++---------------------
>  drivers/usb/serial/mos7840.c       |  2 +-
>  5 files changed, 19 insertions(+), 27 deletions(-)

Please split out (at least) the usb-serial changes into two patches.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/