linux-kernel - Re: [PATCH 06/10] ARM: realview: enable multiplatform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 10 Dec 2015 11:55:17 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Russell King <rmk+kernel@....linux.org.uk>,
	Liviu Dudau <liviu.dudau@....com>,
	Sudeep Holla <sudeep.holla@....com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
	Russell King <linux@....linux.org.uk>
Subject: Re: [PATCH 06/10] ARM: realview: enable multiplatform

On Thursday 10 December 2015 11:04:31 Linus Walleij wrote:
> On Wed, Nov 25, 2015 at 5:32 PM, Arnd Bergmann <arnd@...db.de> wrote:
> 
> > All obstacles are out of the way by now, so we can finally move realview
> > to multiplatform.
> >
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > Acked-by: Linus Walleij <linus.walleij@...aro.org>
> > Cc: Russell King <linux@....linux.org.uk>
> (...)
> 
> > -obj-y                                  := core.o
> >  obj-$(CONFIG_REALVIEW_DT)              += realview-dt.o
> > +ifdef $(CONFIG_ATAGS)
> > +obj-y                                  := core.o
> >  obj-$(CONFIG_MACH_REALVIEW_EB)         += realview_eb.o
> >  obj-$(CONFIG_MACH_REALVIEW_PB11MP)     += realview_pb11mp.o
> >  obj-$(CONFIG_MACH_REALVIEW_PB1176)     += realview_pb1176.o
> >  obj-$(CONFIG_MACH_REALVIEW_PBA8)       += realview_pba8.o
> >  obj-$(CONFIG_MACH_REALVIEW_PBX)                += realview_pbx.o
> > +endif
> 
> This isn't working. Even if CONFIG_ATAGS is set, none of the files
> inside this ifdef $(CONFIG_ATAGS) are compiled. Does Kconfig
> only support if and not ifdef?
> 

Oh, it's a silly typo:

it should be "ifdef CONFIG_ATAGS", not "ifdef $(CONFIG_ATAGS)"

Sorry about that.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/