linux-kernel - Re: [PATCH] usb: remove redundant conditions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zixijr31.fsf@saruman.tx.rr.com>
Date:	Thu, 10 Dec 2015 08:50:10 -0600
From:	Felipe Balbi <balbi@...com>
To:	"Geyslan G. Bem" <geyslan@...il.com>, <peter.senna@...il.com>
CC:	"Geyslan G. Bem" <geyslan@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Johan Hovold <johan@...nel.org>,
	Robert Baldyga <r.baldyga@...sung.com>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: remove redundant conditions


Hi,

"Geyslan G. Bem" <geyslan@...il.com> writes:
> This patch removes redundant conditions.
>
>  - (!A || (A && B)) is the same as (!A || B).
>  - (length && length > 5) can be reduced to a single evaluation.
>
> Caught by: cppcheck
>
> Signed-off-by: Geyslan G. Bem <geyslan@...il.com>

Can you split this into one patch per driver, that way it's easier to
apply by different maintainers.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)