linux-kernel - Re: [PATCH] i2c: allow building emev2 without slave mode again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2592093.cGKEcKVqLU@wuerfel>
Date:	Thu, 10 Dec 2015 16:06:10 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	kbuild test robot <lkp@...el.com>
Cc:	kbuild-all@...org, Wolfram Sang <wsa@...-dreams.de>,
	linux-i2c@...r.kernel.org,
	Niklas Söderlund 
	<niklas.soderlund+renesas@...natech.se>, linux-sh@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: allow building emev2 without slave mode again

On Thursday 10 December 2015 22:54:25 kbuild test robot wrote:
> 
>    In file included from arch/x86/include/asm/realmode.h:5:0,
>                     from arch/x86/include/asm/acpi.h:33,
>                     from arch/x86/include/asm/fixmap.h:19,
>                     from arch/x86/include/asm/apic.h:12,
>                     from arch/x86/include/asm/smp.h:12,
>                     from arch/x86/include/asm/mmzone_64.h:10,
>                     from arch/x86/include/asm/mmzone.h:4,
>                     from include/linux/mmzone.h:856,
>                     from include/linux/gfp.h:5,
>                     from include/linux/device.h:29,
>                     from drivers/i2c/busses/i2c-emev2.c:15:
>    drivers/i2c/busses/i2c-emev2.c: In function 'em_i2c_irq_handler':
> >> arch/x86/include/asm/io.h:53:3: warning: 'value' may be used uninitialized in this function [-Wmaybe-uninitialized]
>     { asm volatile("mov" size " %0,%1": :reg (val), \
>       ^
>    drivers/i2c/busses/i2c-emev2.c:232:13: note: 'value' was declared here
>      u8 status, value;
>                 ^

The warning was indeed introduced by my change, but I think there
was a preexisting issue:

The slave_cb callback function is supposed to set the 'value'
here, but it might return an error not assign the pointer, which
is something that both the rcar and the emev2 drivers do not handle
correctly.

It might be best to change the callback to return 'void' and not
allow it to fail. At least the eeprom slave cannot fail anyway,
and it is the only implementation we have at the moment.
The inline function would then have to be changed to initialize
the 'value'.

Alternatively, the  inline could return an error, and both bus
drivers check for the error before using 'value'.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/