linux-kernel - Re: [PATCH] overlayfs: include linux/pagemap.h for PAGE_CACHE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJfpegvCg+YoS-nV2h4=ydiaGLAtB4g-KwD_bKSCnbts-EScwg@mail.gmail.com>
Date:	Thu, 10 Dec 2015 16:26:56 +0100
From:	Miklos Szeredi <miklos@...redi.hu>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	"linux-unionfs@...r.kernel.org" <linux-unionfs@...r.kernel.org>,
	Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] overlayfs: include linux/pagemap.h for PAGE_CACHE_SIZE

On Thu, Dec 10, 2015 at 4:10 PM, Arnd Bergmann <arnd@...db.de> wrote:
> The overlayfs has started enforcing a maximum file size, but is missing
> the header file that defines the PAGE_CACHE_SIZE constant in some
> configurations.

Hmm, it uses MAX_LFS_FILESIZE.  MAX_LFS_FILESIZE is defined in
<linux/fs.h>, which doesn't include <linux/pagemap.h>.

<linux/pagemap.h> includes <linux/fs.h> however.  So shouldn't
MAX_LFS_FILESIZE be defined in <linux/pagemap.h> instead?

Thanks,
Miklos


>
> fs/overlayfs/super.c: In function 'ovl_fill_super':
> fs/overlayfs/super.c:939:29: error: 'PAGE_CACHE_SIZE' undeclared (first use in this function)
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 7b1746cac878 ("ovl: setattr: check permissions before copy-up")
> Cc: <stable@...r.kernel.org>
> ---
> The patch that introduced this was marked for stable, so I'm marking this
> the same way.
>
> diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
> index ea94e50a3473..a4cbdf9824c7 100644
> --- a/fs/overlayfs/super.c
> +++ b/fs/overlayfs/super.c
> @@ -9,6 +9,7 @@
>
>  #include <linux/fs.h>
>  #include <linux/namei.h>
> +#include <linux/pagemap.h>
>  #include <linux/xattr.h>
>  #include <linux/security.h>
>  #include <linux/mount.h>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/