linux-kernel - Re: [PATCH v5 2/2] video: fbdev: pxafb: initial devicetree conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56699A57.9030209@ti.com>
Date:	Thu, 10 Dec 2015 17:29:27 +0200
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Robert Jarzmik <robert.jarzmik@...e.fr>,
	Rob Herring <robh+dt@...nel.org>
CC:	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	<linux-fbdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 2/2] video: fbdev: pxafb: initial devicetree conversion


On 07/12/15 22:50, Robert Jarzmik wrote:

>> It seems that at least "depth" is missing from the binding document.
> You're right.
> 
> Actually depth is not a "hardware" caracteristic. Moreover it's just used as an
> overlay for pxafb_set_pixfmt() to superseed var->bits_per_pixel. I'm wondering
> if the right path for of_get_pxafb_mode_info() would be to remove completely
> depth, and leave it initialized at 0 for the DT case.
> 
> What do you think of this approach ? The other one would be to modify the
> binding, and yet I feel this depth doesn't belong to the binding, it's my patch
> which requires another spin IMHO.

Yes, we should avoid non-hardware relate properties in the .dts files if
at all possible. If the driver works fine without the property, I think
it's fine to remove it. If it is required it needs to be added to the
binding document.

 Tomi


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)