linux-kernel - Re: [PATCH 6/9v2] usb: host: ehci.h: use space after comma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1512101055570.2395-100000@iolanthe.rowland.org>
Date:	Thu, 10 Dec 2015 10:57:23 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Peter Senna Tschudin <peter.senna@...il.com>
cc:	"Geyslan G. Bem" <geyslan@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 6/9v2] usb: host: ehci.h: use space after comma

On Thu, 10 Dec 2015, Peter Senna Tschudin wrote:

> >  /* next async queue entry, or pointer to interrupt/periodic QH */
> > -#define QH_NEXT(ehci,dma)	(cpu_to_hc32(ehci, (((u32)dma)&~0x01f)|Q_TYPE_QH))
> > +#define QH_NEXT(ehci, dma) \
> > +		(cpu_to_hc32(ehci, (((u32) dma) & ~0x01f) | Q_TYPE_QH))
> 
> For the maintainers: Is having two lines here better than having a line with 83 chars?

Two lines is better.  This patch is fine and so are the other 7 -- I 
never received 9/9v2 (the original 9/9 was okay).

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/