linux-kernel - Re: [PATCH linux-next (v2) 1/3] mtd: brcmnand: Add brcm,bcm6368-nand device tree binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151210023001.GI144338@google.com>
Date:	Wed, 9 Dec 2015 18:30:01 -0800
From:	Brian Norris <computersforpeace@...il.com>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	Simon Arlott <simon@...e.lp0.eu>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	David Woodhouse <dwmw2@...radead.org>,
	linux-mtd@...ts.infradead.org, Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	bcm-kernel-feedback-list@...adcom.com,
	Kamal Dasu <kdasu.kdev@...il.com>,
	Jonas Gorski <jogo@...nwrt.org>
Subject: Re: [PATCH linux-next (v2) 1/3] mtd: brcmnand: Add brcm,bcm6368-nand
 device tree binding

On Wed, Dec 09, 2015 at 01:01:42PM -0800, Florian Fainelli wrote:
> Le 09/12/2015 12:40, Simon Arlott a écrit :
> > Add device tree binding for NAND on the BCM6368.
> > 
> > The BCM6368 has a NAND interrupt register with combined status and enable
> > registers. It also requires a clock, so add an optional clock to the
> > common brcmnand binding.
> > 
> 
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

Applied this and patches 2 and 3 to l2-mtd.git, with one small fix,
below.

> > Signed-off-by: Simon Arlott <simon@...e.lp0.eu>
> > ---
> > Changed "nand-intr-base" reg name to "nand-int-base".
> > 
> >  .../devicetree/bindings/mtd/brcm,brcmnand.txt      | 32 ++++++++++++++++++++++
> >  1 file changed, 32 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt
> > index 4ff7128..ebfa6fc 100644
> > --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt
> > +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt
> > @@ -45,6 +45,8 @@ Required properties:
> >  - #size-cells      : <0>
> >  
> >  Optional properties:
> > +- clock                     : reference to the clock for the NAND controller
> > +- clock-names               : "nand" (required for the above clock)
> >  - brcm,nand-has-wp          : Some versions of this IP include a write-protect
> >                                (WP) control bit. It is always available on >=
> >                                v7.0. Use this property to describe the rare
> > @@ -72,6 +74,12 @@ we define additional 'compatible' properties and associated register resources w
> >         and enable registers
> >       - reg-names: (required) "nand-int-base"
> >  
> > +   * "brcm,nand-bcm6368"
> > +     - compatible: should contain "brcm,nand-bcm<soc>", "brcm,nand-bcm6368"
> > +     - reg: (required) the 'NAND_INTR_BASE' register range, with combined status
> > +       and enable registers, and boot address registers
> > +     - reg-names: (required) "nand-int-base"
> > +
> >     * "brcm,nand-iproc"
> >       - reg: (required) the "IDM" register range, for interrupt enable and APB
> >         bus access endianness configuration, and the "EXT" register range,
> > @@ -148,3 +156,27 @@ nand@...42800 {
> >  		};
> >  	};
> >  };
> > +
> > +nand@...00200 {
> > +	compatible = "brcm,nand-bcm63168", "brcm,nand-bcm6368",
> > +		"brcm,brcmnand-v4.0", "brcm,brcmnand";
> > +	reg = <0x10000200 0x180>,
> > +	      <0x10000600 0x200>,
> > +	      <0x100000b0 0x10>;
> > +	reg-names = "nand", "nand-cache", "nand-intr-base";

s/intr/int/

> > +	interrupt-parent = <&periph_intc>;
> > +	interrupts = <50>;
> > +	clocks = <&periph_clk 20>;
> > +	clock-names = "nand";
> > +
> > +	#address-cells = <1>;
> > +	#size-cells = <0>;
> > +
> > +	nand0: nandcs@0 {
> > +		compatible = "brcm,nandcs";
> > +		reg = <0>;
> > +		nand-on-flash-bbt;
> > +		nand-ecc-strength = <1>;
> > +		nand-ecc-step-size = <512>;
> > +	};
> > +};
> > 
> 
> 
> -- 
> Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/