linux-kernel - Re: [PATCH] [SCSI] osd: fix signed char versus %02x issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vcze4m8OeY=0wuiUtE_LgoifmmhdRKM2sQTAT-_Y3DFjg@mail.gmail.com>
Date:	Thu, 10 Dec 2015 21:10:17 +0200
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	"Martin K. Petersen" <martin.petersen@...cle.com>
Cc:	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Boaz Harrosh <ooo@...ctrozaur.com>,
	Benny Halevy <bhalevy@...marydata.com>,
	"James E.J. Bottomley" <JBottomley@...n.com>, osd-dev@...n-osd.org,
	linux-scsi <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [SCSI] osd: fix signed char versus %02x issue

On Thu, Dec 10, 2015 at 8:15 PM, Martin K. Petersen
<martin.petersen@...cle.com> wrote:
>>>>>> "Rasmus" == Rasmus Villemoes <linux@...musvillemoes.dk> writes:
>
> Rasmus> If char is signed and one of these bytes happen to have a value
> Rasmus> outside the ascii range, the corresponding output will consist
> Rasmus> of "ffffff" followed by the two hex chars that were actually
> Rasmus> intended. One way to fix it would be to change the casts to
> Rasmus> (u8*) aka (unsigned char*), but it is much simpler (and
> Rasmus> generates smaller code) to use the %ph extension which was
> Rasmus> created for such short hexdumps.
>
> Applied to 4.5/scsi-queue.

How fast!

Martin, I have several patches on SCSI subsytem like this one. Some of
them didn't manage kernel (even having Ack!) for years already.
Is it okay if I collect them together and send a bunch once again Cc'ing you?

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/