linux-kernel - Re: [PATCH v4 5/5] crypto: AES CBC multi-buffer glue code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1449765585.3057.9.camel@schen9-desk2.jf.intel.com>
Date:	Thu, 10 Dec 2015 08:39:45 -0800
From:	Tim Chen <tim.c.chen@...ux.intel.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	"David S.Miller" <davem@...emloft.net>,
	Stephan Mueller <smueller@...onox.de>,
	Chandramouli Narayanan <mouli_7982@...oo.com>,
	Vinodh Gopal <vinodh.gopal@...el.com>,
	James Guilford <james.guilford@...el.com>,
	Wajdi Feghali <wajdi.k.feghali@...el.com>,
	Jussi Kivilinna <jussi.kivilinna@....fi>,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 5/5] crypto: AES CBC multi-buffer glue code

On Thu, 2015-12-10 at 09:45 +0800, Herbert Xu wrote:
> On Wed, Dec 09, 2015 at 09:23:14AM -0800, Tim Chen wrote:
> > 
> > This is an internal algorithm.  We are indeed casting the request
> > to the outer ablkcipher request when we do the async cipher walk.
> 
> The question remain: why does it have to be a blkcipher rather
> than an ablkcipher?
> 
> Cheers,

The inner cipher is called synchronously from the outer layer 
async cipher algorithm in cbc_mb_async_ablk_decrypt via

        err = crypto_blkcipher_crt(child_tfm)->decrypt(
                &rctx->desc, req->dst, req->src, req->nbytes);

or directly by mcrytpd_queue_worker via mcryptd_blkcipher_crypt. We
do not allow this operation to return something like EINPROGRESS.  

But the walk of the scattered list is done with async walk.

Thanks.

Tim

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/