linux-kernel - Re: [PATCH] mm/zswap: change incorrect strncmp use to strcmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151211154321.e5b03afe8122d0f5afa38f4d@linux-foundation.org>
Date:	Fri, 11 Dec 2015 15:43:21 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Dan Streetman <ddstreet@...e.org>
Cc:	Weijie Yang <weijie.yang@...sung.com>,
	Seth Jennings <sjennings@...iantweb.net>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH] mm/zswap: change incorrect strncmp use to strcmp

On Fri, 11 Dec 2015 18:33:11 -0500 Dan Streetman <ddstreet@...e.org> wrote:

> Change the use of strncmp in zswap_pool_find_get() to strcmp.
> 
> The use of strncmp is no longer correct, now that zswap_zpool_type is
> not an array; sizeof() will return the size of a pointer, which isn't
> the right length to compare.

whoops

>  We don't need to use strncmp anyway,
> because the existing params and the passed in params are all guaranteed
> to be null terminated, so strcmp should be used.
> 

Thanks, I'll queue this for 4.4.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/