linux-kernel - Re: [PATCH] regmap: cache: Add warning info for the cache check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <566A22B3.3040904@cmss.chinamobile.com>
Date:	Fri, 11 Dec 2015 09:11:15 +0800
From:	Xiubo Li <lixiubo@...s.chinamobile.com>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
CC:	broonie@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regmap: cache: Add warning info for the cache check



On 10/12/2015 20:45, Charles Keepax wrote:
> On Thu, Dec 10, 2015 at 10:40:53AM +0800, Xiubo Li wrote:
>> If there is no cache used for the drivers, the register drfaults
> s/drfaults/defaults/
Yes，Thanks.


>> are not need any more. This patch will check this and print a
>> warning.
>>
>> Signed-off-by: Xiubo Li <lixiubo@...s.chinamobile.com>
>> ---
>>   drivers/base/regmap/regcache.c | 12 ++++++++----
>>   1 file changed, 8 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c
>> index 1c0210a..bdcd401 100644
>> --- a/drivers/base/regmap/regcache.c
>> +++ b/drivers/base/regmap/regcache.c
>> @@ -100,15 +100,19 @@ int regcache_init(struct regmap *map, const struct regmap_config *config)
>>   	int i;
>>   	void *tmp_buf;
>>   
>> -	for (i = 0; i < config->num_reg_defaults; i++)
>> -		if (config->reg_defaults[i].reg % map->reg_stride)
>> -			return -EINVAL;
>> -
>>   	if (map->cache_type == REGCACHE_NONE) {
>> +		if (config->num_reg_defaults)
>> +			dev_warn(map->dev,
>> +				 "No cache used with register defualts set!\n");
> s/defualts/defaults/
See the next version.


Thanks,

BRs

Xiubo

> Thanks,
> Charles



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/