linux-kernel - Re: [PATCH 0/2] staging: COMEDI: checkpatch.pl cleanups in comedi.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <566A9EF8.1050600@mev.co.uk>
Date:	Fri, 11 Dec 2015 10:01:28 +0000
From:	Ian Abbott <abbotti@....co.uk>
To:	Moritz König <moritz.koenig@....de>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Colin Cronin <colinpatrickcronin@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Cc:	Fabian Lang <fabian.lang@....de>, linux-kernel@...cs.fau.de
Subject: Re: [PATCH 0/2] staging: COMEDI: checkpatch.pl cleanups in comedi.h

On 10/12/15 14:57, Moritz König wrote:
> This patchset fixes all the warnings and legitimate checks of
> checkpatch.pl in comedi.h.
>
> The following warnings were fixed:
>   * WARNING: Block comments use * on subsequent lines
>   * WARNING: Block comments use a trailing */ on a separate line
> The following checks were fixed:
>   * CHECK: spaces preferred around that '<<' (ctx:VxV)
>   * CHECK: spaces preferred around that '>>' (ctx:VxV)
>   * CHECK: spaces preferred around that '|' (ctx:VxV)
>
> The following checks are not legitimate here and were not fixed:
>   * CHECK: spaces preferred around that '&' (ctx:VxV)
> 	This '&' is not a binary operator, but a referencing.
>   * CHECK: Prefer using the BIT macro
> 	The author defined a BIT macro here.
>   * CHECK: Avoid CamelCase: <UNIT_mA>
> 	This refers to the unit 'milli ampere'.
>
> Moritz König (2):
>    staging: COMEDI: Fixed the format of comments
>    staging: COMEDI: Added missing spaces at binary operators
>
>   drivers/staging/comedi/comedi.h | 232 +++++++++++++++++++++++-----------------
>   1 file changed, 131 insertions(+), 101 deletions(-)
>

Thanks.  There's an outstanding patch by Daniel H. Hemmingsen that also 
fixes these issues:

http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-November/081778.html

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/