linux-kernel - Re: [PATCH 3/6] Input: psmouse - rearrange Focaltech init code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151211114445.GJ12308@pali>
Date:	Fri, 11 Dec 2015 12:44:45 +0100
From:	Pali Rohár <pali.rohar@...il.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	linux-input@...r.kernel.org, Hans de Goede <hdegoede@...hat.com>,
	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	Thomas Hellstrom <thellstrom@...are.com>, jckeerthan@...il.com,
	till2.schaefer@...-dortmund.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] Input: psmouse - rearrange Focaltech init code

On Saturday 28 November 2015 21:13:53 Dmitry Torokhov wrote:
> The fact that we were calling focaltech_init() even when Focaltech support
> is disabled was confusing. Rearrange the code so that if support is
> disabled we continue to fall through the rest of protocol probing code
> until we get to full reset that Focaltech devices need to work properly.
> 
> Also, replace focaltech_init() with a stub now that it is only called when
> protocol is enabled.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

It's also OK, so

Reviewed-by: Pali Rohár <pali.rohar@...il.com>

-- 
Pali Rohár
pali.rohar@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/