linux-kernel - Re: [PATCH 2/2] usb: serial: remove redundant condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Dec 2015 15:30:48 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	"Geyslan G. Bem" <geyslan@...il.com>, peter.senna@...il.com
Cc:	Johan Hovold <johan@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] usb: serial: remove redundant condition

Hello.

On 12/11/2015 12:46 PM, Geyslan G. Bem wrote:

    It's a bad idea to send 2 different patches with the same subject. I'd use 
"mos7840: " as a prefix in this case.

> This patch removes redundant condition.
>
>   (length && length > 5) can be reduced to a single evaluation.
>
> Tested by compilation only.
> Caught by cppcheck.
>
> Signed-off-by: Geyslan G. Bem <geyslan@...il.com>
[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/