linux-kernel - Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Dec 2015 16:02:33 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Sanidhya Solanki <jpage.lkml@...il.com>
Cc:	lidza.louina@...il.com, markh@...pro.net,
	gregkh@...uxfoundation.org, driverdev-devel@...uxdriverproject.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes

On Fri, Dec 11, 2015 at 03:21:49AM -0500, Sanidhya Solanki wrote:
> >From 1dbe78ce98037da5467d817a9db838d678b338ae Mon Sep 17 00:00:00 2001
> From: Sanidhya Solanki <jpage.lkml@...il.com>
> Date: Fri, 11 Dec 2015 03:08:53 -0500
> Subject: [PATCH] staging: dgnc: Patch includes the checkpatch fixes


Don't include this stuff.

> 
> Patch contains the checkpatch fixes as asked by the TODO.
> TODO file is updated as well.

Fix one type of warning at a time.  This will be a series of patches.

> 
> Signed-off-by: Sanidhya Solanki <jpage.lkml@...il.com>
> @@ -110,7 +98,16 @@ static ssize_t dgnc_vpd_show(struct device *p, struct device_attribute *attr,
>  	int count = 0;
>  	int i = 0;
>  
> -	DGNC_VERIFY_BOARD(p, bd);
> +	do {
> +		if (!p)
> +			return 0;
> +
> +		bd = dev_get_drvdata(p);
> +		if (!bd || bd->magic != DGNC_BOARD_MAGIC)
> +			return 0;
> +		if (bd->state != BOARD_READY)
> +			return 0;
> +	} while (0);

Google about why do while(0) loops are used in macros and then redo
this.  Mostly the patch isn't bad, but I suspect I'm going to complain
about how you split up some of the long lines.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/