linux-kernel - Re: [PATCHv3] printf: Add format for 8-byte EUI-64 type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VejtpH=Dwb=LgdSgL9bs5SXB-dqrEWdGDSg8mRLDgm-Hw@mail.gmail.com>
Date:	Fri, 11 Dec 2015 17:42:27 +0200
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Keith Busch <keith.busch@...el.com>,
	Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:	Joe Perches <joe@...ches.com>, linux-nvme@...ts.infradead.org,
	LKML <linux-kernel@...r.kernel.org>,
	Matthew Wilcox <willy@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jens Axboe <axboe@...com>,
	Christoph Hellwig <hch@...radead.org>,
	Dan Williams <dan.j.williams@...el.com>
Subject: Re: [PATCHv3] printf: Add format for 8-byte EUI-64 type

+Rasmus.

On Thu, Dec 10, 2015 at 5:06 PM, Keith Busch <keith.busch@...el.com> wrote:
> On Wed, Dec 09, 2015 at 03:21:40PM -0800, Joe Perches wrote:
>> On Wed, 2015-12-09 at 16:06 -0700, Keith Busch wrote:
>> > MAC addresses may be formed using rules based on EUI-64, which is 2 bytes
>> > longer than a typical 6-byte MAC. This patch adds a long specifier to
>> > the %pM format to support the extended unique identifier.
>> >
>> > Since there are multiple valid possible permutations of format specifiers,
>> > the decoding is done in a loop, and the default ':' separator is
>> > initialized at declaration time. A side effect of this allows 'F' and
>> > 'R' both be specified, so these are appended to the documentation.
>>
>> Just thought of this:
>>
>> An alternative is using a format of "%8phC"
>>
>> Is there a use case for a bluetooth or FDDI EUI-64?
>
> *facepalm*
>
> I didn't know that format, but it satisfies my needs. I am not aware of
> bluetooth or fddi using eui64, so I've no problem withdrawing the patch.
> I'll just fix up the one that depended on it.

Of course you might try to add reversed support for %*ph.

Also you may consider print_hex_dump() [hex_dump_to_buffer()], though
it looks like overkill in particular here.

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/