linux-kernel - Re: [PATCH v3 4/9] usb: host: ehci.h: fix single statement macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Dec 2015 17:55:13 -0300
From:	"Geyslan G. Bem" <geyslan@...il.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Peter Senna Tschudin <peter.senna@...il.com>,
	Alan Stern <stern@...land.harvard.edu>,
	linux-usb@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 4/9] usb: host: ehci.h: fix single statement macros

2015-12-11 13:30 GMT-03:00 Greg Kroah-Hartman <gregkh@...uxfoundation.org>:
> On Thu, Dec 10, 2015 at 03:18:19PM -0300, Geyslan G. Bem wrote:
>> Don't use the 'do {} while (0)' wrapper in a single statement macro.
>>
>> Caught by checkpatch: "WARNING: Single statement macros should not
>> use a do {} while (0) loop"
>>
>> Signed-off-by: Geyslan G. Bem <geyslan@...il.com>
>> ---
>> Change in v3:
>>  - There's no need to evaluate COUNT(x) in #ifdef EHCI_STATS
>>    false branch. Thus an empty #define is the choice.
>
> Odd numbering scheme of patches, I can't figure this out...
Greg,

I sent new versions only to modified ones.
9 is v1.
4 is v3.
rest is v2.

Next time I'll send new versions for all.

>
> Can you resend this whole series so I know I got it all correct?
I hope so. :-) Messing around with branches and merges here. I tell you soon.

>
> thanks,
>
> greg k-h



-- 
Regards,

Geyslan G. Bem
hackingbits.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/