linux-kernel - Re: [PATCH v2] Input: atmel_mxt_ts - Add maxtouch to I2C table for module autoload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 11 Dec 2015 13:24:22 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Javier Martinez Canillas <javier@....samsung.com>
Cc:	linux-kernel@...r.kernel.org, Nick Dyer <nick.dyer@...ev.co.uk>,
	linux-input@...r.kernel.org
Subject: Re: [PATCH v2] Input: atmel_mxt_ts - Add maxtouch to I2C table for
 module autoload

Hi Javier,

On Thu, Dec 10, 2015 at 08:07:47PM -0300, Javier Martinez Canillas wrote:
> Hello Dmitry,
> 
> On 11/20/2015 04:15 PM, Dmitry Torokhov wrote:
> > On Fri, Nov 20, 2015 at 04:09:42PM -0300, Javier Martinez Canillas wrote:
> >> The Atmel maxtouch DT binding documents that the compatible string for
> >> the device is "atmel,maxtouch" and the I2C core always reports a module
> >> alias of the form i2c:alias where alias is the compatible string model:
> >>
> >> $ grep MODALIAS /sys/devices/platform/12e00000.i2c/i2c-8/8-004b/uevent
> >> MODALIAS=i2c:maxtouch
> > 
> > Do we know why we are not reporting modalias as "of:..." so that
> > autoloading using the of table works properly?
> > 
> > It sounds like the of matching and modalias is quite a mess at the
> > moment.
> >
> 
> I already explained the issues with OF modalias and why I believe
> $SUBJECT is the least bad solution for now until the I2C subsystem
> is changed to properly report OF modalias.
> 
> Please let me know if you are considering applying this or if
> module autoloading will be broken for this driver in the meantime.

My bad, I was going to apply it several times but then my attention
would wander to some other patchset and I'd forget.

Applied now.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/