linux-kernel - Re: [PATCH] iwlwifi: mvm: protect RCU dereference in iwl_mvm_get_key_sta

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <566B4C5F.4050908@redhat.com>
Date:	Fri, 11 Dec 2015 14:21:19 -0800
From:	Laura Abbott <labbott@...hat.com>
To:	Johannes Berg <johannes@...solutions.net>,
	linux-wireless@...r.kernel.org
Cc:	netdev@...r.kernel.org, avri.altman@...el.com,
	emmanuel.grumbach@...el.com, linuxwifi@...el.com,
	linux-kernel@...r.kernel.org,
	Johannes Berg <johannes.berg@...el.com>
Subject: Re: [PATCH] iwlwifi: mvm: protect RCU dereference in
 iwl_mvm_get_key_sta_id

On 12/11/2015 12:13 AM, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@...el.com>
>
> Properly protect the RCU dereference in iwl_mvm_get_key_sta_id() when
> coming from iwl_mvm_update_tkip_key() which cannot hold the mvm->mutex
> by moving the call into the RCU critical section.
> Modify the check to use rcu_dereference_check() to permit this.
>
> Fixes: 9513c5e18a0d ("iwlwifi: mvm: Avoid dereferencing sta if it was already flushed")
> Reported-by: Laura Abbott <labbott@...hat.com>
> Signed-off-by: Johannes Berg <johannes.berg@...el.com>

Thanks, it's working for me.

Tested-by: Laura Abbott <labbott@...hat.com>



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/