linux-kernel - Re: [PATCH] drivers:pci:host Fix missing line after declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 12 Dec 2015 13:23:16 +0100
From:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
To:	Bogicevic Sasa <brutallesale@...il.com>
Cc:	bhelgaas@...gle.com, Richard.Zhu@...escale.com,
	l.stach@...guintronix.com, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers:pci:host Fix missing line after declarations

Dear Bogicevic Sasa,

On Sat, 12 Dec 2015 03:41:48 -0800, Bogicevic Sasa wrote:
> This fixes few warnings about missing line after declarations and one
> no whitespace is necesarry before that "("
> 
> Signed-off-by: Bogicevic Sasa <brutallesale@...il.com>

I am not a big fan of this struct rule that insists in having an empty
line after declarations, I believe when a for() loop or if() condition
has only one line of declaration and one line of useful code, it
doesn't make much sense. But oh well, that's the rule, so let's do it
this way.

> ---
>  drivers/pci/host/pci-imx6.c  | 2 +-
>  drivers/pci/host/pci-mvebu.c | 3 +++
>  drivers/pci/host/pcie-rcar.c | 2 ++
>  3 files changed, 6 insertions(+), 1 deletion(-)

For the pci-mvebu.c part:

Reviewed-by: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/