linux-kernel - Re: [PATCH] staging: netlogic: Coding Style Fix Comparison to NULL could be written with !

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 12 Dec 2015 07:00:29 -0800
From:	Benjamin Young <youngcdev@...il.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	jchandra@...adcom.com, ganesanr@...adcom.com
Cc:	tolga.ceylan@...il.com,
	"open list:STAGING SUBSYSTEM" <devel@...verdev.osuosl.org>,
	open list <linux-kernel@...r.kernel.org>, mravindr@...teon.com
Subject: Re: [PATCH] staging: netlogic: Coding Style Fix Comparison to NULL
 could be written with !

On Sat, Dec 12, 2015 at 06:45:59AM -0800, Benjamin Young wrote:
> Fixed coding style for null comparisons in netlogic driver to be more consistant
> with the rest of the kernel coding style
> 
> Signed-off-by: Benjamin Young <youngcdev@...il.com>
> ---
>  drivers/staging/netlogic/xlr_net.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c
> index 8ae0175..ac93e63 100644
> --- a/drivers/staging/netlogic/xlr_net.c
> +++ b/drivers/staging/netlogic/xlr_net.c
> @@ -147,7 +147,7 @@ static void xlr_net_fmn_handler(int bkt, int src_stnid, int size,
>  		addr = addr - MAC_SKB_BACK_PTR_SIZE;
>  		skb = (struct sk_buff *) *(unsigned long *)addr;
>  		skb->dev = adapter->netdev[port];
> -		if (skb->dev == NULL)
> +		if (!skb->dev)
>  			return;
>  		ndev = skb->dev;
>  		priv = netdev_priv(ndev);
> @@ -878,7 +878,7 @@ static int xlr_setup_mdio(struct xlr_net_priv *priv,
>  	priv->mii_bus->write = xlr_mii_write;
>  	priv->mii_bus->parent = &pdev->dev;
>  	priv->mii_bus->irq = kmalloc(sizeof(int)*PHY_MAX_ADDR, GFP_KERNEL);
> -	if (priv->mii_bus->irq == NULL) {
> +	if (!priv->mii_bus->irq) {
>  		pr_err("irq alloc failed\n");
>  		mdiobus_free(priv->mii_bus);
>  		return -ENOMEM;
> @@ -1037,7 +1037,7 @@ static int xlr_net_probe(struct platform_device *pdev)
>  		priv->nd = (struct xlr_net_data *)pdev->dev.platform_data;
>  		res = platform_get_resource(pdev, IORESOURCE_MEM, port);
>  
> -		if (res == NULL) {
> +		if (!res) {
>  			pr_err("No memory resource for MAC %d\n",
>  					priv->port_id);
>  			err = -ENODEV;
> @@ -1052,7 +1052,7 @@ static int xlr_net_probe(struct platform_device *pdev)
>  		adapter->netdev[port] = ndev;
>  
>  		res = platform_get_resource(pdev, IORESOURCE_IRQ, port);
> -		if (res == NULL) {
> +		if (!res) {
>  			pr_err("No irq resource for MAC %d\n", priv->port_id);
>  			err = -ENODEV;
>  			goto err_gmac;
> -- 
> 2.5.0
> 

Adding broadcom engineers.  (Sorry did not see these adresses in the TODO file origionally)

Thanks,
Benjamin Young
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/