linux-kernel - Re: [PATCH] iio/inkern.c Use list_for_each_entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 12 Dec 2015 17:23:47 +0000
From:	Jonathan Cameron <jic23@...nel.org>
To:	Anshul Garg <aksgarg1989@...il.com>, knaack.h@....de,
	lars@...afoo.de, pmeerw@...erw.net, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio/inkern.c Use list_for_each_entry_safe

On 08/12/15 17:45, Anshul Garg wrote:
> Use list_for_each_entry_safe instead of list_for_each_safe
> and list_entry call.
> 
> Signed-off-by: Anshul Garg <aksgarg1989@...il.com>
Applied to the togreg branch of iio.git - initially pushed out
as testing for the autobuilder to play with it.

Thanks,

Jonathan
> ---
>  drivers/iio/inkern.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
> index c8bad3c..f764eb6 100644
> --- a/drivers/iio/inkern.c
> +++ b/drivers/iio/inkern.c
> @@ -61,12 +61,10 @@ EXPORT_SYMBOL_GPL(iio_map_array_register);
>  int iio_map_array_unregister(struct iio_dev *indio_dev)
>  {
>  	int ret = -ENODEV;
> -	struct iio_map_internal *mapi;
> -	struct list_head *pos, *tmp;
> +	struct iio_map_internal *mapi, *next;
>  
>  	mutex_lock(&iio_map_list_lock);
> -	list_for_each_safe(pos, tmp, &iio_map_list) {
> -		mapi = list_entry(pos, struct iio_map_internal, l);
> +	list_for_each_entry_safe(mapi, next, &iio_map_list, l) {
>  		if (indio_dev == mapi->indio_dev) {
>  			list_del(&mapi->l);
>  			kfree(mapi);
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/