linux-kernel - Re: [PATCH] usb: host: ehci-sched: silence checkpatch warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Dec 2015 23:02:21 -0300
From:	"Geyslan G. Bem" <geyslan@...il.com>
To:	"Geyslan G. Bem" <geyslan@...il.com>
Cc:	Joe Perches <joe@...ches.com>,
	Peter Senna Tschudin <peter.senna@...il.com>,
	Alan Stern <stern@...land.harvard.edu>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: host: ehci-sched: silence checkpatch warning

2015-12-11 22:50 GMT-03:00 Geyslan G. Bem <geyslan@...il.com>:
> This patch moves comment into the else branch avoiding the following
> misleading warning.
>
> "braces {} are not necessary for single statement blocks"
>
> Caught by checkpatch.
>
> Signed-off-by: Geyslan G. Bem <geyslan@...il.com>
> Suggested-by: Joe Perches <joe@...ches.com>
> ---
>  drivers/usb/host/ehci-sched.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c
> index f6e828a..b2af0b3 100644
> --- a/drivers/usb/host/ehci-sched.c
> +++ b/drivers/usb/host/ehci-sched.c
> @@ -1560,13 +1560,10 @@ iso_stream_schedule(
>                                         (stream->ps.bw_period - 1);
>                         stream->ps.phase_uf = start & 7;
>                         reserve_release_iso_bandwidth(ehci, stream, 1);
> -               }
> -
> -               /* New stream is already scheduled; use the upcoming slot */
> -               else {
> +               } else {
> +                       /* New stream is already scheduled; use the upcoming slot */
>                         start = (stream->ps.phase << 3) + stream->ps.phase_uf;
>                 }
> -
>                 stream->next_uframe = start;
>                 new_stream = true;
>         }
> --
> 2.6.3
>

This one must be applied only after the bunch [PATCH 00/10] usb: host:
ehci-sched: cleanup
https://lkml.org/lkml/2015/12/11/940


-- 
Regards,

Geyslan G. Bem
hackingbits.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/