linux-kernel - Re: [PATCH] Staging: iio: accel: Fixed NULL comparison style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151213110744.GC5177@mwanda>
Date:	Sun, 13 Dec 2015 14:07:44 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Bhaktipriya Shridhar <bhaktipriya96@...il.com>,
	Joe Perches <joe@...ches.com>
Cc:	jic23@...nel.org, knaack.h@....de, lars@...afoo.de,
	pmeerw@...erw.net, gregkh@...uxfoundation.org,
	ciorneiioana@...il.com, cristina.moraru09@...il.com,
	josselin.costanzi@...ile-devices.fr, linux-iio@...r.kernel.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: iio: accel: Fixed NULL comparison style

On Sun, Dec 13, 2015 at 12:54:27PM +0300, Bhaktipriya Shridhar wrote:
> This patch fixes checkpatch.pl check:
> CHECK: Comparison to NULL could be written "!rx_p"
> +       if (*rx_p == NULL) {
> 

Actually it should be "if (!*rx_p)".  checkpatch.pl appears to have a
bug here.

regards,
dan carpenter

> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@...il.com>
> ---
>  drivers/staging/iio/accel/sca3000_ring.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/accel/sca3000_ring.c b/drivers/staging/iio/accel/sca3000_ring.c
> index 20b878d..5339b10 100644
> --- a/drivers/staging/iio/accel/sca3000_ring.c
> +++ b/drivers/staging/iio/accel/sca3000_ring.c
> @@ -48,7 +48,7 @@ static int sca3000_read_data(struct sca3000_state *st,
>  		}
>  	};
>  	*rx_p = kmalloc(len, GFP_KERNEL);
> -	if (*rx_p == NULL) {
> +	if (!rx_p) {
>  		ret = -ENOMEM;
>  		goto error_ret;
>  	}
> -- 
> 2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/