linux-kernel - Re: [PATCH v2 01/10] usb: host: ehci-sched: refactor scan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1512131027130.7951-100000@netrider.rowland.org>
Date:	Sun, 13 Dec 2015 10:29:07 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	"Geyslan G. Bem" <geyslan@...il.com>
cc:	peter.senna@...il.com, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v2 01/10] usb: host: ehci-sched: refactor scan_isoc
 function

On Sun, 13 Dec 2015, Geyslan G. Bem wrote:

> This patch removes an infinite 'for' loop and makes use of the already
> existing 'restart' tag instead, reducing one leading tab.
> 
> It also puts the easier evaluation (live variable) to be the first in
> two conditionals.
> 
>   if (live && frame == now_frame) { ...
> 
>   if (live && ((frame == now_frame) || ...

You should never do this.  The first test in a conditional should be 
the one that is most likely to cause the expression to fail.  In this 
case, live is almost always true whereas frame == now_frame is true 
only some percentage of the time.  Therefore the frame == now_frame 
test should come first.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/