linux-kernel - [PATCH] checkpatch: detect leading * in NULL comparison check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1450029592-476-1-git-send-email-sgilles@math.umd.edu>
Date:	Sun, 13 Dec 2015 12:59:52 -0500
From:	"S. Gilles" <sgilles@...h.umd.edu>
To:	Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>,
	linux-kernel@...r.kernel.org
Cc:	"S. Gilles" <sgilles@...h.umd.edu>
Subject: [PATCH] checkpatch: detect leading * in NULL comparison check

Prevent checkpatch.pl from emitting messages like

  CHECK: Comparison to NULL could be written "!rx_p"
  #51: FILE: drivers/staging/iio/accel/sca3000_ring.c:51:
  +       if (*rx_p == NULL) {

by checking for leading * characters in the comparison value.

Signed-off-by: S. Gilles <sgilles@...h.umd.edu>
---

I've run this through everything in staging/ as a test, it seems to
work okay.

 scripts/checkpatch.pl | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d4960f7..e549d59 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -4995,10 +4995,10 @@ sub process {
 
 # check for pointer comparisons to NULL
 		if ($^V && $^V ge 5.10.0) {
-			while ($line =~ /\b$LvalOrFunc\s*(==|\!=)\s*NULL\b/g) {
-				my $val = $1;
+			while ($line =~ /([\*]*)\b$LvalOrFunc\s*(==|\!=)\s*NULL\b/g) {
+				my $val = $1 . $2;
 				my $equal = "!";
-				$equal = "" if ($4 eq "!=");
+				$equal = "" if ($5 eq "!=");
 				if (CHK("COMPARISON_TO_NULL",
 					"Comparison to NULL could be written \"${equal}${val}\"\n" . $herecurr) &&
 					    $fix) {
-- 
2.6.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/