linux-kernel - Re: [PATCH 0/9] Fix checkpatch errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 13 Dec 2015 19:26:04 +0100
From:	Frederik <frederik.voelkel@....de>
To:	Nicolai Stange <nicstange@...il.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, jslaby@...e.com,
	linux-kernel@...cs.fau.de, lukas.braun@....de
Subject: Re: [PATCH 0/9] Fix checkpatch errors

On Sun, 13. Dec 19:15, Nicolai Stange wrote:
> Frederik <frederik.voelkel@....de> writes:
> 
> > On Sat, 12. Dec 23:06, Greg KH wrote:
> >> On Fri, Dec 11, 2015 at 11:36:00AM +0100, Frederik Völkel wrote:
> >> > This patch series fixes all checkpatch error in 68328serial.c except
> >> > 5 trailing whitespace errors we are unsure how to fix.
> >> 
> >> What are the errors you are not sure how to fix?
> >> 
> >> thanks,
> >> 
> >> greg k-h
> >
> > All 5 errors are at comments. It is not clear to us where exactly the
> > trailing whitespace is checkpatch complains(lines 271, 770, 889, 993
> > and 1040).
> 
> W/o your series applied (so line numbering might be slightly
> different), checkpatch.pl says:
> 
>   ERROR: trailing whitespace
>   #270: FILE: -:270:
>   +^I * This do { } while() loop will get ALL chars out of Rx FIFO $
> 
> AFAICS, your patch [7/9] ("drivers: tty: 68328serial.c: remove trailing
> whitespaces") doesn't fix this one.
> 
> In good old regexp tradition, the '$' sign denotes the end of line. So,
> there is a single space after "FIFO" and before the end of line.
> 
> If you happen to be Emacs users, consider trying out whitespace-mode.
> If not, try to find another way to make your editor visualize whitespace
> somehow.

Oh right I see. We will fix that and resend.

Thank you!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/