linux-kernel - Re: [PATCH/RFC 08/16] perf tools: Export a couple of hist functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Dec 2015 00:17:04 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Andi Kleen <andi@...stfloor.org>,
	Stephane Eranian <eranian@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>
Subject: Re: [PATCH/RFC 08/16] perf tools: Export a couple of hist functions

On Thu, Dec 10, 2015 at 04:53:27PM +0900, Namhyung Kim wrote:
> These are necessary for multi threaded sample processing:
> 
>  - hists__get__get_rotate_entries_in()
>  - hists__collapse_insert_entry()
>  - __hists__init()
> 
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> ---
>  tools/perf/util/hist.c | 19 ++++++++++++-------
>  tools/perf/util/hist.h |  5 +++++
>  2 files changed, 17 insertions(+), 7 deletions(-)
> 
> diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
> index d534ed76164b..ea4f3ad978b0 100644
> --- a/tools/perf/util/hist.c
> +++ b/tools/perf/util/hist.c
> @@ -972,9 +972,8 @@ void hist_entry__delete(struct hist_entry *he)
>   * collapse the histogram
>   */
>  
> -static bool hists__collapse_insert_entry(struct hists *hists __maybe_unused,
> -					 struct rb_root *root,
> -					 struct hist_entry *he)
> +bool hists__collapse_insert_entry(struct hists *hists __maybe_unused,
> +				  struct rb_root *root, struct hist_entry *he)
>  {
>  	struct rb_node **p = &root->rb_node;
>  	struct rb_node *parent = NULL;
> @@ -1014,7 +1013,7 @@ static bool hists__collapse_insert_entry(struct hists *hists __maybe_unused,
>  	return true;
>  }
>  
> -static struct rb_root *hists__get_rotate_entries_in(struct hists *hists)
> +struct rb_root *hists__get_rotate_entries_in(struct hists *hists)
>  {
>  	struct rb_root *root;
>  
> @@ -1549,10 +1548,8 @@ int perf_hist_config(const char *var, const char *value)
>  	return 0;
>  }
>  
> -static int hists_evsel__init(struct perf_evsel *evsel)
> +int __hists__init(struct hists *hists)

and this one also ;-)

Acked-by: Jiri Olsa <jolsa@...nel.org>


thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/