lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 14 Dec 2015 10:21:39 +0100 From: Jacek Anaszewski <j.anaszewski@...sung.com> To: Paul Gortmaker <paul.gortmaker@...driver.com> Cc: linux-kernel@...r.kernel.org, Bryan Wu <cooloney@...il.com>, Linus Walleij <linus.walleij@...aro.org>, Richard Purdie <rpurdie@...ys.net>, linux-leds@...r.kernel.org Subject: Re: [PATCH 0/3] leds: avoid module usage in non-modular code On 12/13/2015 10:45 PM, Paul Gortmaker wrote: > This series of commits is a part of a larger project to ensure > people don't reference modular support functions in non-modular > code. Overall there was roughly 5k lines of dead code in the > kernel due to this. So far we've fixed several areas, like tty, > x86, net, ... and we continue to work on other areas. > > There are several reasons to not use module support for code that > can never be built as a module, but the big ones are: > > (1) it is easy to accidentally code up unused module_exit and remove code > (2) it can be misleading when reading the source, thinking it can be > modular when the Makefile and/or Kconfig prohibit it > (3) it requires the include of the module.h header file which in turn > includes nearly everything else. > > For the LED subsystem, there are just three commits. Two are basically > trivial remapping to the appropriate non-modular counterparts. The > third also has a change to block driver unbinding since that doesn't > make any sense and it allows us to delete the .remove code. We've > already made similar unbind changes like this in drivers/tty. > > Patches created on linux-next and build tested for ARM allmodconfig. > > Paul. > --- > > Cc: Bryan Wu <cooloney@...il.com> > Cc: Linus Walleij <linus.walleij@...aro.org> > Cc: Jacek Anaszewski <j.anaszewski@...sung.com> > Cc: Richard Purdie <rpurdie@...ys.net> > Cc: linux-leds@...r.kernel.org > > Paul Gortmaker (3): > drivers/leds: make trigger/ledtrig-cpu.c driver explicitly non-modular > drivers/leds: make trigger/ledtrig-ide-disk.c driver explicitly non-modular > drivers/leds: make leds-syscon.c explicitly non-modular > > drivers/leds/leds-syscon.c | 18 +++--------------- > drivers/leds/trigger/ledtrig-cpu.c | 26 +------------------------- > drivers/leds/trigger/ledtrig-ide-disk.c | 14 +------------- > 3 files changed, 5 insertions(+), 53 deletions(-) > Patch set applied, thanks. -- Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists