linux-kernel - Re: [PATCH 2/2] powerpc: tracing: don't trace hcalls on offline CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1450087241.9595.0.camel@ellerman.id.au>
Date:	Mon, 14 Dec 2015 21:00:41 +1100
From:	Michael Ellerman <mpe@...erman.id.au>
To:	Steven Rostedt <rostedt@...dmis.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	Denis Kirjanov <kda@...ux-powerpc.org>, linuxppc-dev@...abs.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] powerpc: tracing: don't trace hcalls on offline CPUs

On Mon, 2015-12-07 at 16:33 -0500, Steven Rostedt wrote:
> On Tue, 08 Dec 2015 08:02:15 +1100
> Benjamin Herrenschmidt <benh@...nel.crashing.org> wrote:
> > On Mon, 2015-12-07 at 15:52 -0500, Steven Rostedt wrote:
> > > > +     TP_CONDITION(cpu_online(smp_processor_id())),
> > > > +  
> > 
> > This should probably be some kind of __raw version though, hcalls can
> > be called in contexts where the debug stuff in smp_processor_id() isn't
> > safe (or preempt enabled).
> > 
> 
> OK, then that needs to be updated.

Denis, please respin with raw_smp_processor_id().

cheers

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/