linux-kernel - Re: [PATCH] extcon: max14577: fix handling return value of regmap_irq_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJKOXPei0yF0jAe1m_1ZChzjPnnb7Mra3n3pmnnYzqqSGEKARw@mail.gmail.com>
Date:	Mon, 14 Dec 2015 19:31:42 +0900
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Andrzej Hajda <a.hajda@...sung.com>
Cc:	Chanwoo Choi <cw00.choi@...sung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	MyungJoo Ham <myungjoo.ham@...sung.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] extcon: max14577: fix handling return value of regmap_irq_get_virq

2015-12-14 19:06 GMT+09:00 Andrzej Hajda <a.hajda@...sung.com>:
> The function can return negative values, so its result should
> be assigned to signed variable.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
>
> Signed-off-by: Andrzej Hajda <a.hajda@...sung.com>
> ---
>  drivers/extcon/extcon-max14577.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>

Do you plan to fix also max77693?

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/