[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20151214103220.GB9449@krava.brq.redhat.com>
Date: Mon, 14 Dec 2015 11:32:20 +0100
From: Jiri Olsa <jolsa@...hat.com>
To: Josh Poimboeuf <jpoimboe@...hat.com>
Cc: Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>,
linux-kernel@...r.kernel.org, Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH v3 15/17] perf: Finalize subcmd independence
On Sun, Dec 13, 2015 at 10:18:15PM -0600, Josh Poimboeuf wrote:
> For the files that will be moved to the subcmd library, remove all their
> perf-specific includes and duplicate any needed functionality.
>
> Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com>
> ---
> tools/perf/util/exec_cmd.c | 75 +++++++++++++++++++++++++++++++++++++----
> tools/perf/util/help.c | 47 +++++++++++++++++++++++---
> tools/perf/util/help.h | 4 ++-
> tools/perf/util/pager.c | 7 +++-
> tools/perf/util/parse-options.c | 68 +++++++++++++++++++++++--------------
> tools/perf/util/parse-options.h | 2 +-
> tools/perf/util/run-command.c | 16 ++++++---
> tools/perf/util/run-command.h | 2 ++
> tools/perf/util/sigchain.c | 3 +-
> tools/perf/util/subcmd-util.h | 67 ++++++++++++++++++++++++++++++++++++
> tools/perf/util/util.h | 14 --------
> 11 files changed, 247 insertions(+), 58 deletions(-)
this duplicates functions that we have already in perf,
I think we better move them into lib first..
strlcpy, die, xrealloc, ALLOC_GROW
and probably some others...
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists