linux-kernel - Re: [PATCH 01/38] arm-cci: fix handling cpumask_any

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <566EAB2E.3030407@arm.com>
Date:	Mon, 14 Dec 2015 11:42:38 +0000
From:	"Suzuki K. Poulose" <Suzuki.Poulose@....com>
To:	Andrzej Hajda <a.hajda@...sung.com>,
	<linux-kernel@...r.kernel.org>, "Arnd Bergmann" <arnd@...db.de>
CC:	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Punit Agrawal <punit.agrawal@....com>,
	"Will Deacon" <will.deacon@....com>,
	Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH 01/38] arm-cci: fix handling cpumask_any_but return value

On 14/12/15 10:20, Andrzej Hajda wrote:
> Hi,
>
> Ping - almost three months passed.

Andrzej,

The cci patches normally go via the arm-soc tree (which is not quit obvious).
Unfortunately, your post didn't have the maintainers alias - arm@...r.kernel.org -
added (except for Arnd).

Arnd,

What do you recommend ? Should Adrzej send the patch again (with arm@...r.kernel.org in
Cc) or could you pick this one up ?

Regards
Suzuki


>
> Regards
> Andrzej
>
> On 09/21/2015 03:33 PM, Andrzej Hajda wrote:
>> cpumask_any_but returns value >= nr_cpu_ids if there are no more CPUs.
>>
>> The problem has been detected using proposed semantic patch
>> scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
>>
>> [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
>>
>> Signed-off-by: Andrzej Hajda <a.hajda@...sung.com>
>> ---
>>   drivers/bus/arm-cci.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
>> index 577cc4b..22754d0 100644
>> --- a/drivers/bus/arm-cci.c
>> +++ b/drivers/bus/arm-cci.c
>> @@ -1314,7 +1314,7 @@ static int cci_pmu_cpu_notifier(struct notifier_block *self,
>>              if (!cpumask_test_and_clear_cpu(cpu, &cci_pmu->cpus))
>>                      break;
>>              target = cpumask_any_but(cpu_online_mask, cpu);
>> -            if (target < 0) // UP, last CPU
>> +            if (target >= nr_cpu_ids) // UP, last CPU
>>                      break;
>>              /*
>>               * TODO: migrate context once core races on event->ctx have
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>


________________________________

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/