linux-kernel - Bad backport of "net: Fix skb_set_peeked use-after-free bug" in 3.18.23

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151214024426.GA23275@iris.ozlabs.ibm.com>
Date:	Mon, 14 Dec 2015 13:44:26 +1100
From:	Paul Mackerras <paulus@...abs.org>
To:	Sasha Levin <sasha.levin@...cle.com>, linux-kernel@...r.kernel.org
Cc:	Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>, stable@...r.kernel.org
Subject: Bad backport of "net: Fix skb_set_peeked use-after-free bug" in
 3.18.23

Commit d9a1133495b4 ("net: Fix skb_set_peeked use-after-free bug") in
3.18.23 claims to be a backport of commit a0a2a6602496, but in fact
the patch is identical to commit 738ac1ebb96d ("net: Clone skb before
setting peeked flag"), which is the commit that introduces the
use-after-free bug that a0a2a6602496 fixes.

The result is that we have been seeing crashes in __skb_recv_datagram
since I merged v3.18.24 into the kernel code we are using for a
product.  Could someone fix this with an actual backport of
a0a2a6602496 please?

Thanks,
Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/