linux-kernel - Re: [PATCH] gpio: zynq: Do PM initialization earlier to support gpio hogs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYsOtzc_TnRA=CuvQMFNpgrMHhUvLu1kRQFynk5wLNz0w@mail.gmail.com>
Date:	Mon, 14 Dec 2015 14:10:31 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Michal Simek <michal.simek@...inx.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Michal Simek <monstr@...str.eu>,
	Sören Brinkmann <soren.brinkmann@...inx.com>,
	Steffen Trumtrar <s.trumtrar@...gutronix.de>,
	Peter Crosthwaite <peter.crosthwaite@...inx.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Rob Herring <robherring2@...il.com>,
	Alexandre Courbot <gnurou@...il.com>,
	Josh Cartwright <josh.cartwright@...com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] gpio: zynq: Do PM initialization earlier to support gpio hogs

On Thu, Dec 10, 2015 at 12:10 PM, Michal Simek <michal.simek@...inx.com> wrote:

> GPIO hogs registration is call at the end of gpiochip_add() function.
> Calling sequence is:
> gpiochip_add -> of_gpiochip_add -> of_gpiochip_scan_hogs ->
> gpiod_hog -> gpiochip_request_own_desc -> __gpiod_request ->
> chip->request -> zynq_gpio_request which calls pm_runtime_get_sync()
> which returns -13 because PM is not initialized yet.
>
> Initialize PM before gpiochip_add is called to fix this issue.
>
> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> Signed-off-by: Soren Brinkmann <soren.brinkmann@...inx.com>

Patch applied!

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/