linux-kernel - [PATCH] clk: unchecked return of kmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Dec 2015 14:16:55 +0100
From:	Nicholas Mc Guire <hofrat@...dl.org>
To:	Michael Turquette <mturquette@...libre.com>
Cc:	Stephen Boyd <sboyd@...eaurora.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	Heiko Stuebner <heiko@...ech.de>, linux-clk@...r.kernel.org,
	linux-kernel@...r.kernel.org, Nicholas Mc Guire <hofrat@...dl.org>
Subject: [PATCH] clk: unchecked return of kmalloc_array

kmalloc_array return is unchecked - given how parent_names is being treated
in case of allocation error it probably is ok to treat clock->parents the
same way and simply return.

problem was located with coccinelle

Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>
---

patch was compile tested for shmobile_defconfig
(implies CONFIG_ARCH_SHMOBILE_MULTI=y)

patch is against linux-next (localversion-next -next-20151214)

 drivers/clk/shmobile/clk-div6.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/clk/shmobile/clk-div6.c b/drivers/clk/shmobile/clk-div6.c
index b4c8d67..e6b7533 100644
--- a/drivers/clk/shmobile/clk-div6.c
+++ b/drivers/clk/shmobile/clk-div6.c
@@ -196,6 +196,8 @@ static void __init cpg_div6_clock_init(struct device_node *np)
 
 	clock->parents = kmalloc_array(num_parents, sizeof(*clock->parents),
 		GFP_KERNEL);
+	if (!clock->parents)
+		return;
 	parent_names = kmalloc_array(num_parents, sizeof(*parent_names),
 				GFP_KERNEL);
 	if (!parent_names)
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/