linux-kernel - Re: [PATCH v2] sched/fair: fix mul overflow on 32-bit systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151214143528.GP6357@twins.programming.kicks-ass.net>
Date:	Mon, 14 Dec 2015 15:35:28 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Andrey Ryabinin <aryabinin@...tuozzo.com>
Cc:	mingo@...hat.com, bsegall@...gle.com, dietmar.eggemann@....com,
	linux-kernel@...r.kernel.org, yuyang.du@...el.com, pjt@...gle.com,
	morten.rasmussen@....com
Subject: Re: [PATCH v2] sched/fair: fix mul overflow on 32-bit systems

On Mon, Dec 14, 2015 at 03:47:23PM +0300, Andrey Ryabinin wrote:
> Make 'r' 64-bit type to avoid overflow in 'r * LOAD_AVG_MAX'
> on 32-bit systems:
> 	UBSAN: Undefined behaviour in kernel/sched/fair.c:2785:18
> 	signed integer overflow:
> 	87950 * 47742 cannot be represented in type 'int'
> 
> Fixes: 9d89c257dfb9 ("sched/fair: Rewrite runnable load and utilization average tracking")
> Signed-off-by: Andrey Ryabinin <aryabinin@...tuozzo.com>

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/