linux-kernel - Re: [PATCH v3 15/17] perf: Finalize subcmd independence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151214155107.GP6843@kernel.org>
Date:	Mon, 14 Dec 2015 12:51:07 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Josh Poimboeuf <jpoimboe@...hat.com>
Cc:	Jiri Olsa <jolsa@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH v3 15/17] perf: Finalize subcmd independence

Em Mon, Dec 14, 2015 at 08:13:59AM -0600, Josh Poimboeuf escreveu:
> On Mon, Dec 14, 2015 at 11:32:20AM +0100, Jiri Olsa wrote:
> > On Sun, Dec 13, 2015 at 10:18:15PM -0600, Josh Poimboeuf wrote:
> > > For the files that will be moved to the subcmd library, remove all their
> > > perf-specific includes and duplicate any needed functionality.
> > > 
> > > Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com>
> > > ---
> > >  tools/perf/util/exec_cmd.c      | 75 +++++++++++++++++++++++++++++++++++++----
> > >  tools/perf/util/help.c          | 47 +++++++++++++++++++++++---
> > >  tools/perf/util/help.h          |  4 ++-
> > >  tools/perf/util/pager.c         |  7 +++-
> > >  tools/perf/util/parse-options.c | 68 +++++++++++++++++++++++--------------
> > >  tools/perf/util/parse-options.h |  2 +-
> > >  tools/perf/util/run-command.c   | 16 ++++++---
> > >  tools/perf/util/run-command.h   |  2 ++
> > >  tools/perf/util/sigchain.c      |  3 +-
> > >  tools/perf/util/subcmd-util.h   | 67 ++++++++++++++++++++++++++++++++++++
> > >  tools/perf/util/util.h          | 14 --------
> > >  11 files changed, 247 insertions(+), 58 deletions(-)
> > 
> > this duplicates functions that we have already in perf,
> > I think we better move them into lib first..
> >   strlcpy, die, xrealloc, ALLOC_GROW

Some stuff should move to other, non-subcmd libraries that will then be
used by both subcmd, tools/perf/, etc, while some we take the oportunity
to kill, like die() and perhaps strbuf :-)

> > and probably some others...
> 
> The duplication was an intentional decision we made in the v2 discussion
> in order to keep the library's scope focused on 'subcmd'.

Ok, I merged a good chunk now, will push soon.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/