linux-kernel - Re: [PATCH v3.1 02/17] tools build: Fix feature Makefile dependencies for 'O='

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151214160336.GD11552@treble.redhat.com>
Date:	Mon, 14 Dec 2015 10:03:36 -0600
From:	Josh Poimboeuf <jpoimboe@...hat.com>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	linux-kernel@...r.kernel.org, Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH v3.1 02/17] tools build: Fix feature Makefile
 dependencies for 'O='

On Mon, Dec 14, 2015 at 04:55:28PM +0100, Jiri Olsa wrote:
> On Mon, Dec 14, 2015 at 09:38:15AM -0600, Josh Poimboeuf wrote:
> > On Mon, Dec 14, 2015 at 04:29:39PM +0100, Jiri Olsa wrote:
> > > On Mon, Dec 14, 2015 at 08:29:07AM -0600, Josh Poimboeuf wrote:
> > > > Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com>
> > > 
> > > you might want to work on your changelogs
> > > a little..  aaand actually include some ;-)
> > 
> > Well, I thought the subject said it all :-)
> 
> well, you could be more specific, like:
> - how was it broken before
> - what did you do to fix it
> - how you added a test case to ensure this will never happen again ;-)
> 
> it makes the life of reviewer a bit easier, anyway:
> 
> Acked-by: Jiri Olsa <jolsa@...nel.org>

Thanks.  I'll try to be more verbose in future changelogs.

-- 
Josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/