linux-kernel - Re: [PATCH v2] extcon: add Maxim MAX3355 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Dec 2015 01:29:19 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Rob Herring <robh@...nel.org>
Cc:	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	MyungJoo Ham <myungjoo.ham@...sung.com>,
	Chanwoo Choi <cw00.choi@...sung.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	SH-Linux <linux-sh@...r.kernel.org>,
	Linux USB List <linux-usb@...r.kernel.org>
Subject: Re: [PATCH v2] extcon: add Maxim MAX3355 driver

Hello.

On 12/15/2015 01:21 AM, Rob Herring wrote:

>>>> Maxim  Integrated MAX3355E chip integrates a  charge pump and comparators
>>>> to
>>>> enable a system with an integrated USB OTG dual-role transceiver to
>>>> function
>>>> as  an USB  OTG dual-role device.  In addition  to sensing/controlling
>>>> Vbus,
>>>> the chip also passes thru the ID signal  from the USB  OTG connector.
>>>> On some Renesas boards,  this signal is  just fed into the SoC thru a
>>>> GPIO
>>>> pin --  there's no real  OTG controller, only host and gadget USB
>>>> controllers
>>>> sharing the same USB bus; however, we'd  like to allow host or gadget
>>>> drivers
>>>> to be loaded depending on the cable type,  hence the need for the MAX3355
>>>> extcon driver. The Vbus status signals are also  wired to GPIOs (however,
>>>> we
>>>> aren't currently interested in them),  the OFFVBUS# signal is controlled
>>>> by
>>>> the host controllers, there's  also the SHDN# signal wired to a GPIO, it
>>>> should be driven high for the  normal operation.
>>>
>>>
>>> As multiple people have said, fix the spacing here.
>>
>>
>>     You are the first to complain abou _this_ patch. If you don't have other
>> issues with this driver in which case you should have trimmed the reply at
>> this point), I'd like to keep my spacing as is. Thank you.
>
> Your previous version was not "extcon-usb-gpio: add enable pin
> support"[1] which has now been re-written to be max3355 specific?

    No, the MAX3355 driver pre-dates that version. First there was a driver, 
then I tried to re-use the existing stuff (there was no extcon-usb-gpio at the 
time of writing my driver), then had to return to the separate driver idea...

> "So
> what" and "I'd like to keep my spacing as is" aren't valid reasons.
> Fix it, then I'll look at the rest again.

    I'll consider doing that if you care to explain what's the problem with my 
spacing. TIA.

> Rob

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/