[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <566F99FA.5090007@roeck-us.net>
Date: Mon, 14 Dec 2015 20:41:30 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Mikael Starvik <starvik@...s.com>
Cc: Jesper Nilsson <jesper.nilsson@...s.com>,
linux-cris-kernel@...s.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] cris: debugport: Fix section mismatches
On 11/10/2015 02:04 PM, Guenter Roeck wrote:
> Section mismatches can now cause build failures, such as for
> cris:allnoconfig. Rename affected variables to end with _console
> to make section mismatch checks happy.
>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
ping ...
cris:allnoconfig still fails to build in mainline.
Should I drop the build from my tests ?
Thanks,
Guenter
> ---
> arch/cris/arch-v10/kernel/debugport.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/arch/cris/arch-v10/kernel/debugport.c b/arch/cris/arch-v10/kernel/debugport.c
> index 7d307cce8bd8..b6549e54be29 100644
> --- a/arch/cris/arch-v10/kernel/debugport.c
> +++ b/arch/cris/arch-v10/kernel/debugport.c
> @@ -468,7 +468,7 @@ etrax_console_device(struct console* co, int *index)
> #endif
> }
>
> -static struct console sercons = {
> +static struct console ser_console = {
> name : "ttyS",
> write: console_write,
> read : NULL,
> @@ -480,7 +480,7 @@ static struct console sercons = {
> cflag : 0,
> next : NULL
> };
> -static struct console sercons0 = {
> +static struct console ser0_console = {
> name : "ttyS",
> write: console_write,
> read : NULL,
> @@ -493,7 +493,7 @@ static struct console sercons0 = {
> next : NULL
> };
>
> -static struct console sercons1 = {
> +static struct console ser1_console = {
> name : "ttyS",
> write: console_write,
> read : NULL,
> @@ -505,7 +505,7 @@ static struct console sercons1 = {
> cflag : 0,
> next : NULL
> };
> -static struct console sercons2 = {
> +static struct console ser2_console = {
> name : "ttyS",
> write: console_write,
> read : NULL,
> @@ -517,7 +517,7 @@ static struct console sercons2 = {
> cflag : 0,
> next : NULL
> };
> -static struct console sercons3 = {
> +static struct console ser3_console = {
> name : "ttyS",
> write: console_write,
> read : NULL,
> @@ -539,17 +539,17 @@ init_etrax_debug(void)
> static int first = 1;
>
> if (!first) {
> - unregister_console(&sercons);
> - register_console(&sercons0);
> - register_console(&sercons1);
> - register_console(&sercons2);
> - register_console(&sercons3);
> + unregister_console(&ser_console);
> + register_console(&ser0_console);
> + register_console(&ser1_console);
> + register_console(&ser2_console);
> + register_console(&ser3_console);
> init_dummy_console();
> return 0;
> }
>
> first = 0;
> - register_console(&sercons);
> + register_console(&ser_console);
> start_port(port);
> #ifdef CONFIG_ETRAX_KGDB
> start_port(kgdb_port);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists