linux-kernel - Re: [PATCH] tty/n_gsm.c: fix false positive WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <566FA86B.6060408@linux.vnet.ibm.com>
Date:	Tue, 15 Dec 2015 13:43:07 +0800
From:	Pan Xinhui <xinhui.pan@...ux.vnet.ibm.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	linux-kernel@...r.kernel.org, Jiri Slaby <jslaby@...e.com>,
	dvyukov@...gle.com, yanmin_zhang@...ux.intel.com
Subject: Re: [PATCH] tty/n_gsm.c: fix false positive WARN_ON and do some codes
 improvement

Hi, Greg
	This patch is dropped, I have created another patch based on Jiri' patch.
On 2015/12/15 02:55, Greg Kroah-Hartman wrote:
> On Wed, Nov 25, 2015 at 07:18:37PM +0800, xinhui wrote:
>> From: xinhui <xinhui@...ux.vnet.ibm.com>
>>
>> If gsm driver fails to activate one mux, and this mux is not stored in
>> gsm_mux[], there would be a warning in gsm_cleanup_mux(). Actually this
>> is a legal case. So just do a simple check instead of WARN_ON.
>>
>> There is one filed gsm->num to store its index of gsm_mux[]. So use
>> gsm->num to remove itself from gsm_mux[] instead of the for-loop
>> traverse.
>>
>> Reported-by: Dmitry Vyukov <dvyukov@...gle.com>
>> Fixes: 5a64096700dc ("tty/n_gsm.c: fix a memory leak in gsmld_open")
>> Signed-off-by: Pan Xinhui <xinhui.pan@...ux.vnet.ibm.com>
>
> the signed-off-by name has to match your from: name :(
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/