linux-kernel - Re: [PATCH 1/3] staging: dgnc: Patch includes the checkpatch fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Dec 2015 12:07:07 +0530
From:	Amitoj Kaur Chawla <amitoj1606@...il.com>
To:	Sanidhya Solanki <jpage.lkml@...il.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>, devel@...verdev.osuosl.org,
	driverdev-devel@...uxdriverproject.org,
	linux-kernel@...r.kernel.org,
	Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH 1/3] staging: dgnc: Patch includes the checkpatch fixes

On Tue, Dec 15, 2015 at 7:28 AM, Sanidhya Solanki <jpage.lkml@...il.com> wrote:
>
> Patch contains the spacing fixes that led to checkpatch.pl warnings.
>
> Signed-off-by: Sanidhya Solanki <jpage.lkml@...il.com>
> ---
>  drivers/staging/dgnc/dgnc_cls.c    |   4 +-
>  drivers/staging/dgnc/dgnc_driver.h |   8 --
>  drivers/staging/dgnc/dgnc_neo.c    | 235
> ++++++++++++++++++++++++-------------
> drivers/staging/dgnc/dgnc_neo.h    |  22 ++--
> drivers/staging/dgnc/dgnc_pci.h    |   1 -
> drivers/staging/dgnc/dgnc_sysfs.c  |  18 ++-
> drivers/staging/dgnc/dgnc_tty.c    |  46 +++++---
> drivers/staging/dgnc/digi.h        |  32 ++--- 8 files changed, 223
> insertions(+), 143 deletions(-)
>

Hi Sanidhya,

Just to help you out since you're struggling some.

Subject line should be something like "Fix checkpatch warnings".
Better yet would be a subject specifying what you fixed to silence
checkpatch warnings. For example, "Fixed comments formatting" or
"Removed unnecessary spaces"

And the commit message should not be vague like "Patch contains the
spacing fixes that led to checkpatch.pl warnings." You should write
what you did to fix the warnings.
For example: Fixed checkpatch warning *write warning here* by
correcting *whatever change you did*

Regards,
Amitoj
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/