linux-kernel - Re: [PATCH] net/mlx4_core: fix handling return value of mlx4_slave_convert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <566FD8D4.5030506@mellanox.com>
Date:	Tue, 15 Dec 2015 11:09:40 +0200
From:	Or Gerlitz <ogerlitz@...lanox.com>
To:	Andrzej Hajda <a.hajda@...sung.com>
CC:	Jack Morgenstein <jackm@....mellanox.co.il>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eran Ben Elisha <eranbe@...lanox.com>,
	Hadar Hen Zion <hadarh@...lanox.com>,
	Moni Shoua <monis@...lanox.com>,
	Yishai Hadas <yishaih@...lanox.com>,
	Maor Gottlieb <maorg@...lanox.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net/mlx4_core: fix handling return value of
 mlx4_slave_convert_port

On 12/14/2015 12:05 PM, Andrzej Hajda wrote:
> The function can return negative values, so its result should
> be assigned to signed variable.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
>

Please add here

Fixes: fc48866f7 ('net/mlx4: Adapt code for N-Port VF')


> Signed-off-by: Andrzej Hajda <a.hajda@...sung.com>

otherwise, Looks good

Acked-by: Or Gerlitz <ogerlitz@...lanox.com>

Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/