lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 15 Dec 2015 10:08:47 +0900 From: Chanwoo Choi <cw00.choi@...sung.com> To: Andrzej Hajda <a.hajda@...sung.com>, Krzysztof Kozlowski <k.kozlowski@...sung.com> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>, Marek Szyprowski <m.szyprowski@...sung.com>, MyungJoo Ham <myungjoo.ham@...sung.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] extcon: max77693: fix handling return value of regmap_irq_get_virq On 2015년 12월 14일 20:12, Andrzej Hajda wrote: > The function can return negative values, so its result should > be assigned to signed variable. > > Signed-off-by: Andrzej Hajda <a.hajda@...sung.com> > Suggested-by: Krzysztof Kozlowski <k.kozlowski@...sung.com> > --- > drivers/extcon/extcon-max77693.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c > index 44c499e..fdf8f5d 100644 > --- a/drivers/extcon/extcon-max77693.c > +++ b/drivers/extcon/extcon-max77693.c > @@ -1127,11 +1127,11 @@ static int max77693_muic_probe(struct platform_device *pdev) > /* Support irq domain for MAX77693 MUIC device */ > for (i = 0; i < ARRAY_SIZE(muic_irqs); i++) { > struct max77693_muic_irq *muic_irq = &muic_irqs[i]; > - unsigned int virq = 0; > + int virq; > > virq = regmap_irq_get_virq(max77693->irq_data_muic, > muic_irq->irq); > - if (!virq) > + if (virq <= 0) > return -EINVAL; > muic_irq->virq = virq; > > Applied it. Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists